[ 
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190318#comment-17190318
 ] 

Erick Erickson commented on SOLR-14723:
---------------------------------------

Please do!

Find all of the solrconfig.xml files (unix find . -name solrconfig.xml) and 
replace the above with 
{code}
    <filterCache size="512"
                 initialSize="512"
                 autowarmCount="0"/>
{code}

Really, just remove the "class=" bits from all the cache entries. There should 
be 3-4 of them in each solrconfig.xml file.

You should run "gw check" on the code afterwards. If some tests fail, try 
rerunning the test with the commands that'll be printed out "reproduce 
with....". there are some tests that sometimes fail (we're working on it). The 
point here is don't automatically assume that your changes caused the failure 
unless it reproduces consistently.

Then create a patch or a PR if you're git-savvy and attach it to this JIRA. Git 
will automatically do the associations for a PR if you include "SOLR-14723: 
Rremove the class atribute for the caches in the _default/example configsets" 
in the title.

If you choose to attach a patch file, just call it SOLR-14723.patch. Subsequent 
patches should have the same name, the JIRA system will automatically handle it.

Then ping this JIRA asking for review/commit.

Thanks for volunttering! This will be a good thing to get your feet wet, 
understand the build system, how to run tests and all that.

> Rremove the class atribute for the caches in the _default/example configsets
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-14723
>                 URL: https://issues.apache.org/jira/browse/SOLR-14723
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Tomas Eduardo Fernandez Lobbe
>            Priority: Trivial
>              Labels: newdev
>
> In 8.x branch, the default and example configsets include LRUCache and 
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> <filterCache class="solr.FastLRUCache"
>                  size="512"
>                  initialSize="512"
>                  autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute 
> completely and let the default take over (as it's in master), this should 
> make upgrading configsets easier:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to