[ 
https://issues.apache.org/jira/browse/LUCENE-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160510#comment-17160510
 ] 

Erick Erickson commented on LUCENE-9433:
----------------------------------------

Here's what's in this PR (1680)

These tasks run successfully
./gradlew check
./gradlew documentation

I don't know of any build failures, but then I didn't try every task.

Everyone:

Other than the gradle/ant-compat directory, I think I've removed everything 
that mentions ant or ivy. If there are any obscure files that are part of the 
Ant build, please don't hesitate to point them out. I happened on 
"CustomizedAsciidoctorAntTask.java" mostly by chance for instance, and I _hope_ 
it's not necessary. I'll check some more as work progresses.

[~ctargett] and/or [~hossman] 

There are a few things relating to the ref guide that make me a bit nervous, 
for example:

deleted: solr/solr-ref-guide/tools/CustomizedAsciidoctorAntTask.java
 deleted: solr/solr-ref-guide/tools/asciidoctor-antlib.xml

Is the "documentation" task sufficient to insure that the changes I made won't 
break the ref guide build? If not, any suggestions?

[~dweiss] and/or [~tomoko] 
For this checkpoint I didn't touch anything in gradle/ant-compat. Any wisdom to 
offer? When I looked at some of the files I'm not clear what should be changed 
and what should be left alone. For instance:


- forbidden-api-rules-in-sync.gradle has this comment:
 // Just make sure the forbidden API rules are in sync between gradle and ant 
versions until
 // we get rid of ant build.

which leads me to believe I should delete the file and fix wherever it's 
referenced.

- force-versions.gradle doesn't seem to be something that should be changed.

- artifact-naming.gradle just confuses me on a cursory look.

I know Dawid had to expend considerable effort making the Gradle build mimic 
some things done by the Ant build. Should we leave it this way or change to 
"the gradle way"? By that I mean wherever we are doing things in a non-standard 
way according to Gradle conventions to play nice with the ant build, follow 
standard Gradle practices instead. What all these would be is TBD.

 

> Remove Ant support from trunk
> -----------------------------
>
>                 Key: LUCENE-9433
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9433
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Items that may need to be addressed:
>  * Testing with OpenJDK early access releases
>  * Mavenizing
>  * Test speed (?)
>  * check build for ref guide
>  * Update Confluence



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to