dsmiley commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r450229934
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##########
@@ -500,6 +508,31 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
}
}
+ private void tagRequestWithRequestId(ResponseBuilder rb) {
+ final boolean ridTaggingDisabled =
rb.req.getParams().getBool(CommonParams.DISABLE_REQUEST_ID, false);
+ if (! ridTaggingDisabled) {
+ String rid = getRequestId(rb.req);
+ if
(StringUtils.isBlank(rb.req.getParams().get(CommonParams.REQUEST_ID))) {
+ ModifiableSolrParams params = new
ModifiableSolrParams(rb.req.getParams());
Review comment:
> "It either autogenerates a request ID or uses whatever you pass in.
There's also a flag to disable it if you want"
That's also an X, Y, and Z :-)
In my suggestion, the consequence of a blank rid needn't be a special case
-- treat it as valid if you like. It's super-short "rid=" and so adds
negligible noise when propagated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
