gerlowskija commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r450182894
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##########
@@ -500,6 +508,31 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
}
}
+ private void tagRequestWithRequestId(ResponseBuilder rb) {
+ final boolean ridTaggingDisabled =
rb.req.getParams().getBool(CommonParams.DISABLE_REQUEST_ID, false);
+ if (! ridTaggingDisabled) {
+ String rid = getRequestId(rb.req);
+ if
(StringUtils.isBlank(rb.req.getParams().get(CommonParams.REQUEST_ID))) {
+ ModifiableSolrParams params = new
ModifiableSolrParams(rb.req.getParams());
Review comment:
I guess I just see that as being more complex. Imagine describing that
behavior to a newcomer in one sentence: "Well if you don't specify it at all we
do X, if you do specify it we do Y, and if you specify it as blank we do Z".
Versus: "It either autogenerates a request ID or uses whatever you pass in.
There's also a flag to disable it if you want".
I'm the first to admit these sort of takes are subjective though. If
someone else chimes in here and I get outnumbered I'll change it for sure. But
I'll stick to my guns for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
