gerlowskija commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r448635969
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##########
@@ -510,14 +510,18 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
}
private void tagRequestWithRequestId(ResponseBuilder rb) {
- String rid = getRequestId(rb.req);
- if (StringUtils.isBlank(rb.req.getParams().get(CommonParams.REQUEST_ID))) {
- ModifiableSolrParams params = new
ModifiableSolrParams(rb.req.getParams());
- params.add(CommonParams.REQUEST_ID, rid);//add rid to the request so
that shards see it
- rb.req.setParams(params);
- }
- if (rb.isDistrib) {
- rb.rsp.addToLog(CommonParams.REQUEST_ID, rid); //to see it in the logs
of the landing core
+ final String disableFlag =
rb.req.getParams().get(CommonParams.DISABLE_REQUEST_ID);
Review comment:
Man you're quick on the reviews.
I like a SolrParam better than a cluster property. Users might well have
reasons to enable/disable it differently based on the source or type of query.
A Cluster Property doesn't offer that sort of granularity (at least, as I
understand them).
I don't feel super strongly though, so if you disagree with that rationale,
lmk. I'm gearing up to commit soon-ish.
(I did change to getBool though as you suggested. I initially avoided this
because I thought it'd be nice to have any value for this param disable the
`rid`. But that didn't really fit in with how other similar flags work, so I
scrapped the idea.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
