bruno-roustant commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r448472837
########## File path: lucene/core/src/java/org/apache/lucene/store/EncryptingDirectory.java ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.store; + +import java.io.IOException; + +public abstract class EncryptingDirectory extends FilterDirectory { + + protected EncryptingDirectory(Directory directory) { + super(directory); + } + + @Override + public IndexOutput createOutput(String name, IOContext context) + throws IOException { + IndexOutput indexOutput = in.createOutput(name, context); + byte[] key = getKey(name); + return key == null ? indexOutput : createEncryptingIndexOutput(indexOutput, key); + } + + @Override + public IndexOutput createTempOutput(String prefix, String suffix, IOContext context) throws IOException { + IndexOutput indexOutput = in.createTempOutput(prefix, suffix, context); + byte[] key = getKey(indexOutput.getName()); + return key == null ? indexOutput : createEncryptingIndexOutput(indexOutput, key); + } + + @Override + public IndexInput openInput(String name, IOContext context) + throws IOException { + IndexInput indexInput = in.openInput(name, context); + byte[] key = getKey(name); + return key == null ? indexInput : createEncryptingIndexInput(indexInput, key); + } + + /** + * Gets the encryption key for the provided file name. + * @return The key; or null if none, in this case the data is not encrypted. + */ + protected abstract byte[] getKey(String fileName); Review comment: javax.crypto.Cipher clones the key. But another Encrypter implementation could read the key bytes to create another AES key, without needing to clone. I'll let it as a byte[] and I'll be clear in the javadoc it is not modified and not referenced. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
