juanka588 commented on a change in pull request #1608: URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r448853099
########## File path: lucene/core/src/java/org/apache/lucene/util/crypto/AesCtrEncrypter.java ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.util.crypto; + +import java.nio.ByteBuffer; + +/** + * Stateful Encrypter specialized for AES algorithm in CTR (counter) mode with no padding. + * <p>In CTR mode, encryption and decryption are actually the same operation, so this API does not require to specify + * whether it is used to encrypt or decrypt.</p> + * <p>An {@link AesCtrEncrypter} must be first {@link #init(long) initialized} before it can be used to + * {@link #process(ByteBuffer, ByteBuffer) encrypt/decrypt}.</p> + * <p>Not thread safe.</p> + * + * @lucene.experimental + */ +public interface AesCtrEncrypter extends Cloneable { + + /** + * Initializes this encrypter at the provided CTR block counter (counter of blocks of size {@link EncryptionUtil#AES_BLOCK_SIZE}). + * <p>For example, the data byte at index i is inside the block at counter = i / {@link EncryptionUtil#AES_BLOCK_SIZE}. + * CTR mode computes an IV for this block based on the initial IV (at counter 0) and the provided counter. This allows + * efficient random access to encrypted data. Only the target block needs to be decrypted.</p> + * <p>This method must be called first. Then the next call to {@link #process(ByteBuffer, ByteBuffer)} will start at the + * beginning of the block: the first byte of data at input buffer {@link ByteBuffer#position()} must be the first byte + * of the block.</p> + */ + void init(long counter); Review comment: setPosition(), setBlockPosoition(), moveToBlock()? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org