murblanc commented on a change in pull request #1548:
URL: https://github.com/apache/lucene-solr/pull/1548#discussion_r433397191
##########
File path: solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
##########
@@ -79,40 +78,57 @@ private void testFillWorkQueue() throws Exception {
QUEUE_OPERATION, MOCK_COLL_TASK.toLower(),
ASYNC, String.valueOf(i),
- "sleep", (i == 0 ? "1000" : "1") //first task waits for 1 second,
and thus blocking
- // all other tasks. Subsequent tasks only wait for 1ms
+ // third task waits for a long time, and thus blocks the queue for
all other tasks for A_COLL.
+ // Subsequent tasks as well as the first two only wait for 1ms
+ "sleep", (i == 2 ? "10000" : "1")
)));
log.info("MOCK task added {}", i);
+ }
+ // Wait until we see the first two A_COLL tasks getting processed
+ boolean acoll0done = false, acoll1done = false;
Review comment:
Extracted two methods and simplified flow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
