murblanc commented on pull request #1548:
URL: https://github.com/apache/lucene-solr/pull/1548#issuecomment-636968293


   > While we're here, can we split the `test()` method into 5 proper tests 
instead of bunching them all together?
   
   It's been that way since day 1 of that file (2014?) I assume for speed 
reasons. I tested both variants (IntelliJ and ant), the separate tests seem 
slower (45 seconds to 1m15s in IntelliJ, 2 minutes to 2m30s or so in ant). I 
see 16 instances of Solr being started when tests are run separately and only 4 
when a single test method does everything.
   
   I have no preference.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to