murblanc opened a new pull request #1548:
URL: https://github.com/apache/lucene-solr/pull/1548


   
   # Description
   
   Make MultiThreadedOCPTest.testFillWorkQueue() less vulnerable to timing 
issues when test or overseer code are being slowed down by external factors 
(load, GC etc).
   
   # Solution
   
   A combination of verifying preconditions (to fail with a meaningful messages 
helping pinpoint issues for future test hardening), longer task execution time 
(that **does not delay** total test runtime) and do light synchronization 
between test steps and Overseeer processing progress. 
   
   # Tests
   
   This _is_ a test.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [X] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [X] I have developed this patch against the `master` branch.
   - [X] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to