[
https://issues.apache.org/jira/browse/SOLR-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051236#comment-17051236
]
Andrzej Bialecki commented on SOLR-13942:
-----------------------------------------
[~noble.paul] and [~ichattopadhyaya] - I understand Jan's concern here, because
you've just added a new, powerful and totally undocumented API to Solr just a
moment before the release, and when he pushed back you largely ignored his
concerns instead of trying to find a better solution.
So, in CTR workflow, if there are valid concerns and the original committer
ignores them, IMHO a veto is a justified way to draw his attention and force
the discussion, in order to arrive at a better solution.
Having said that, I also accept that there is at least a temporary need in 8x
for accessing the full content of Solr state data (wherever it might be, in ZK
or in a DB or elsewhere) without actually accessing the ZK native API, so I see
the merit for adding an API like this.
The API that was added has no documentation whatsoever, and only rudimentary
testing. I don't buy the argument that since it's an expert API it should be
intentionally undocumented - this smells of security through obscurity, and
builds a tech debt in terms of the missing docs for public APIs. Just from this
point of view the work here is NOT done - we need the documentation and more
comprehensive tests.
Here's my strawman proposal how to proceed:
* revert (or don't revert) but address Jan's concerns before the 8.5 release,
plus:
* mark the API as experimental, both in the docs and in the API output
* add RefGuide documentation
* add more tests - this is a powerful new API and it has just one basic test?
come on.
> /api/cluster/zk/* to fetch raw ZK data
> --------------------------------------
>
> Key: SOLR-13942
> URL: https://issues.apache.org/jira/browse/SOLR-13942
> Project: Solr
> Issue Type: New Feature
> Components: v2 API
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Blocker
> Fix For: 8.5
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> example
> download the {{state.json}} of
> {code}
> GET http://localhost:8983/api/cluster/zk/collections/gettingstarted/state.json
> {code}
> get a list of all children under {{/live_nodes}}
> {code}
> GET http://localhost:8983/api/cluster/zk/live_nodes
> {code}
> If the requested path is a node with children show the list of child nodes
> and their meta data
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
