mikemccand commented on a change in pull request #1235: LUCENE-8929: parallel early termination sharing counts and max scores across leaves URL: https://github.com/apache/lucene-solr/pull/1235#discussion_r374736845
########## File path: lucene/core/src/java/org/apache/lucene/search/MaxScoreTerminator.java ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; + +/** + * MaxScoreTerminator is notified periodically by leaf collectors calling {@link #update} Review comment: Maybe state up front that this only applies in the static (index time) sort case, when the query's requested sort order is congruent (also sorting by that index time sort)? And also (ideally?) applies to the concurrent case, where separate threads are searching each segment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
