mikemccand commented on a change in pull request #1235: LUCENE-8929: parallel
early termination sharing counts and max scores across leaves
URL: https://github.com/apache/lucene-solr/pull/1235#discussion_r374734594
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -69,6 +69,107 @@ public void setScorer(Scorable scorer) throws IOException {
}
}
+ private abstract class TopFieldLeafCollector extends
MultiComparatorLeafCollector {
Review comment:
This source (`TopFieldCollector.java`) has really become too crazy ... we
should at some point pull all these inner classes out to their own source files
... thank you for opening https://issues.apache.org/jira/browse/LUCENE-9202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
