mikemccand commented on a change in pull request #1235: LUCENE-8929: parallel
early termination sharing counts and max scores across leaves
URL: https://github.com/apache/lucene-solr/pull/1235#discussion_r374733272
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -310,14 +338,18 @@ public void collect(int doc) throws IOException {
final int numHits;
final HitsThresholdChecker hitsThresholdChecker;
- final FieldComparator.RelevanceComparator firstComparator;
+ final FieldComparator.RelevanceComparator relevanceComparator;
final boolean canSetMinScore;
+ final FieldComparator<?> firstComparator;
- // an accumulator that maintains the maximum of the segment's minimum
competitive scores
+ // an accumulator that maintains the maximum of the segments' minimum
competitive scores
final MaxScoreAccumulator minScoreAcc;
// the current local minimum competitive score already propagated to the
underlying scorer
float minCompetitiveScore;
+ // Enables global early termination using minimum competitive scores and
collected counts of all segments
Review comment:
Maybe also say "with concurrent search threads"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
