rmuir commented on a change in pull request #1141: SOLR-14147 change the
Security manager to default to true.
URL: https://github.com/apache/lucene-solr/pull/1141#discussion_r373784401
##########
File path: solr/bin/solr.cmd
##########
@@ -1187,8 +1187,8 @@ IF "%ENABLE_REMOTE_JMX_OPTS%"=="true" (
set REMOTE_JMX_OPTS=
)
-REM Enable java security manager (limiting filesystem access and other things)
-IF "%SOLR_SECURITY_MANAGER_ENABLED%"=="true" (
+REM Enable java security manager by default (limiting filesystem access and
other things)
+IF NOT DEFINED SOLR_SECURITY_MANAGER_ENABLED (
Review comment:
Sorry, maybe my comment was confusing, this logic is not correct. we need
two "IF".
We don't need to change anything about the existing logic, but we need to
introduce a new IF above it to set the default. something like this:
```
REM Enable by default (if the variable is not set by the user, we set it to
true)
IF NOT DEFINED SOLR_SECURITY_MANAGER_ENABLED(
set SOLR_SECURITY_MANAGER_ENABLED=true
)
...
REM Existing logic in master (Unchanged)
IF "%SOLR_SECURITY_MANAGER_ENABLED%"=="true" (
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
