rmuir commented on a change in pull request #1141: SOLR-14147 change the
Security manager to default to true.
URL: https://github.com/apache/lucene-solr/pull/1141#discussion_r373753500
##########
File path: solr/bin/solr
##########
@@ -2086,14 +2086,14 @@ else
REMOTE_JMX_OPTS=()
fi
-# Enable java security manager (limiting filesystem access and other things)
-if [ "$SOLR_SECURITY_MANAGER_ENABLED" == "true" ]; then
+# Disable java security manager (allowing filesystem access and other things)
+if [ "${SOLR_SECURITY_MANAGER_ENABLED:-true}" == "true" ]; then
Review comment:
I think this logic may be reversed. It is true (or unset, in which case it
defaults to true), we want to enable the thing. It can be seen from looking
quickly at the admin UI at system properties, to determine if you correctly
enabled this setting. you will see `java.security.manager` flag set in the
system properties part of the admin UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
