MarcusSorealheis commented on issue #1141: SOLR-14147 change the Security manager to default to true. URL: https://github.com/apache/lucene-solr/pull/1141#issuecomment-570972609 Thanks again. On Sun, Jan 5, 2020 at 5:21 PM Robert Muir <notificati...@github.com> wrote: > *@rmuir* commented on this pull request. > ------------------------------ > > In solr/bin/solr > <https://github.com/apache/lucene-solr/pull/1141#discussion_r363132488>: > > > @@ -2084,14 +2084,14 @@ else > REMOTE_JMX_OPTS=() > fi > > -# Enable java security manager (limiting filesystem access and other things) > -if [ "$SOLR_SECURITY_MANAGER_ENABLED" == "true" ]; then > +# Disable java security manager (allowing filesystem access and other things) > +if [ "$SOLR_SECURITY_MANAGER_ENABLED" == "false" ]; then > > I think we may prefer the bashism of if [ > "${SOLR_SECURITY_MANAGER_ENABLED:-true}" == "true" ] for consistency > elsewhere in the script. it makes it clear that if its undefined, it will > default to true. > > the windows file solr.cmd needs to be changed too. Currently this pull > request doesn't change anything for windows. for windows CMD, I think it is > clearest to just put a IF NOT DEFINED before the check. see that linked > patch for an example. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene-solr/pull/1141?email_source=notifications&email_token=AAR6TSFX65YYQA3OS4JMG5DQ4KBQPA5CNFSM4KCVFJWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQWCH4I#pullrequestreview-338437105>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAR6TSF6H73UPEK3NRZMWELQ4KBQPANCNFSM4KCVFJWA> > . > -- Marcus Eagan
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
