[
https://issues.apache.org/jira/browse/SOLR-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018234#comment-17018234
]
Christine Poerschke commented on SOLR-13965:
--------------------------------------------
GraphHandler and StreamHandler code sharing/duplication was mentioned both here
and on the pull request.
SOLR-13965.01.patch factors out a static
{{StreamHandler.addExpressiblePlugins}} method which GraphHandler could then
use too.
(Note that this does _not_ fix the
{{SolrConfig.classVsSolrPluginInfo.get(Expressible.class)}} suspected bug that
[~mdrob] mentioned on the PR – {{Expressible.class}} vs.
{{Expressible.class.getName()}} was the suspected type mismatch there, right?)
> Adding new functions to GraphHandler should be same as Streamhandler
> --------------------------------------------------------------------
>
> Key: SOLR-13965
> URL: https://issues.apache.org/jira/browse/SOLR-13965
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
> Affects Versions: 8.3
> Reporter: David Eric Pugh
> Priority: Minor
> Attachments: SOLR-13965.01.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently you add new functions to GraphHandler differently than you do in
> StreamHandler. We should have one way of extending the handlers that support
> streaming expressions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
