[
https://issues.apache.org/jira/browse/SOLR-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020476#comment-17020476
]
Christine Poerschke commented on SOLR-13965:
--------------------------------------------
bq. ... The patch doesn't appear to include any new or modified tests. Please
justify why no new tests are needed for this patch. Also please list what
manual steps were performed to verify this patch. ...
SOLR-13965.01.patch is a straightforward method factoring out that is
(hopefully) covered by existing tests. Lucene/Solr QA ran the {{core}} tests
and I ran the {{solrj}} tests locally; they both passed.
> Adding new functions to GraphHandler should be same as Streamhandler
> --------------------------------------------------------------------
>
> Key: SOLR-13965
> URL: https://issues.apache.org/jira/browse/SOLR-13965
> Project: Solr
> Issue Type: Improvement
> Components: streaming expressions
> Affects Versions: 8.3
> Reporter: David Eric Pugh
> Priority: Minor
> Attachments: SOLR-13965.01.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently you add new functions to GraphHandler differently than you do in
> StreamHandler. We should have one way of extending the handlers that support
> streaming expressions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
