madrob commented on issue #1157: Add RAT check using Gradle
URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573887216
 
 
   Updated based on your patch, pushed latest to this PR.
   
   We're missing rat check on `buildSrc` (no ant equivalent), `lucene/tools` 
(does not have build.gradle file), and `dev-tools` (ant rat misses this too) - 
not sure which of those need to be addressed here.
   
   There's definitely something else going on here as one of the excluded files 
from ant is either skipped or passes on Gradle, so more digging needs to happen 
here.
   
   One other question of best practices - do we want all the project exclusions 
in a central rat.gradle file, or spread out and local to each project?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to