dweiss commented on a change in pull request #1157: Add RAT check using Gradle URL: https://github.com/apache/lucene-solr/pull/1157#discussion_r366734419
########## File path: gradle/validation/rat-sources.gradle ########## @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import groovy.xml.NamespaceBuilder + +configure(rootProject) { + configurations { + rat + } + + dependencies { + rat "org.apache.rat:apache-rat" + } +} + +allprojects { + task("rat", type: RatTask) { + group = 'Verification' + description = 'Runs Apache Rat checks.' + } + + if (project == rootProject) { + rat { + includes += [ + "buildSrc/**/*.java", + "lucene/tools/forbiddenApis/**", + "lucene/tools/prettify/**", + // "dev-tools/**" + ] + excludes += [ + // Unclear if this needs ASF header, depends on how much was copied from ElasticSearch + "**/ErrorReportingTestListener.java" + ] + } + } + + if (project.path == ":lucene:analysis:common") { + rat { + srcExcludes += [ + "**/*.aff", + "**/*.dic", + "**/charfilter/*.htm*", + "**/*LuceneResourcesWikiPage.html" + ] + } + } + + if (project.path == ":lucene:analysis:kuromoji") { + rat { + srcExcludes += [ + // whether rat detects this as binary or not is platform dependent?! + "**/bocchan.utf-8" + ] + } + } + + if (project.path == ":lucene:analysis:opennlp") { + rat { + excludes += [ + "src/tools/test-model-data/*.txt", + ] + } + } + + if (project.path == ":lucene:highlighter") { + rat { + srcExcludes += [ + "**/CambridgeMA.utf8" + ] + } + } + + if (project.path == ":lucene:suggest") { + rat { + srcExcludes += [ + "**/Top50KWiki.utf8", + "**/stop-snowball.txt" + ] + } + } + + if (project.path == ":lucene:tools") { + rat { + includes += [ + "forbiddenApis/**", + "prettify/**", + // If/when :lucene:tools becomes a gradle project, then the following line will fail Review comment: I don't think there will be lucene:tools anymore once we depart from ant - I don't think there is any relevant code in there that should stay. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
