pauldoo commented on PR #16145: URL: https://github.com/apache/lucene/pull/16145#issuecomment-6441130239
I independently came across this problem and proposed a solution here: https://github.com/apache/lucene/pull/16804 I've closed my PR in favor of this one. --- > A smaller SKIP shortens the blind window when a mostly cached file starts getting evicted, but none of our benchmarks exercise that transition. So I'd go with 128 as a middle ground but 256 is fine with me too. > I think it's worth keeping it at 64 because the narrower window provides meaningful feedback to the system. I would err on the side of setting a larger value in this PR to reduce the risk of introducing a performance regression for someone, while still being incrementally better than what is in main today. I chose an interval of 1024 in my work. I chose this as it has negligible impact on the hot data benchmarks, while still offering fast-enough response to sudden data eviction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
