gsmiller commented on PR #16145: URL: https://github.com/apache/lucene/pull/16145#issuecomment-6294003484
> On the N - 1 point, that's what I was thinking when I wrote this [...] Ah, I did miss that. Apologies. Glad the idea seemed to work out. As one more follow up, I wonder at this point if having the separate initialization path for "preloaded" files makes sense. I don't necessarily have a strong opinion either way, but if we're initializing to `N - 1` in the default scenario now, I wonder if saving that extra probe when we "know" the file is preloaded helps much. Maybe worth considering a simplification there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
