[
https://issues.apache.org/jira/browse/SOLR-13970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989484#comment-16989484
]
Munendra S N commented on SOLR-13970:
-------------------------------------
I encountered this JIRA when looking into SOLR-13194 (expand with grouping) and
after little searching I found SOLR-11974 (collapsing test failure with
grouping).
Few comments from SOLR-11974, (stack trace is different is tests LeafReader is
wrap in {{AssertingLeafReader}})
{quote}This is a problem with the oas.search.Grouping class: the grouping
collector is created via a post filter and is then consumed twice, which breaks
the invariant that collectors are called on increasing doc ids. Could someone
who is more familiar with grouping and post filters help look into it?{quote}
{quote}
I was surprised to see that we have test case that involved Grouping with the
CollapsingQParserPlugin. The CollapsingQParserPlugin really should only be used
with results that have not already been collapsed or grouped.{quote}
I was able to reproduce the test failure. Based on comments and test failures I
raised the patch.
I couldn't think of any use case where both collapse and grouping are required
and I have never used this combination anywhere
> Collapse/Expand and Grouping are not designed to work together, we should
> fail requests that specify both gracefully
> --------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-13970
> URL: https://issues.apache.org/jira/browse/SOLR-13970
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Munendra S N
> Priority: Major
> Attachments: SOLR-13970.patch
>
>
> Expand/Collapse was conceived as orthogonal to grouping, and there are odd
> interactions when both are specified. If these two options are specified, we
> should reject the query with an informative message.
> Shorter term, making this explicit in the documents would be helpful.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
