[
https://issues.apache.org/jira/browse/SOLR-13970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993640#comment-16993640
]
Munendra S N commented on SOLR-13970:
-------------------------------------
[^SOLR-13970.patch]
Latest patch with above changes incorporated.
{quote}Does SOLR-7798 fix the NPE with expand? Does grouping and expand have a
specific conflict? If it does then let's add the exception as you
suggested.{quote}
This has been added.
{quote}I think the big problem now is not if finish() is being called, but
whether we can call the same PostFilter twice without resetting its internal
state. This is a bigger review problem which involves understanding the inner
working of each postfilter. So my suggestion is rather then putting in another
token check that we address the whole problem of postfilters with grouping in a
different ticket (SOLR-14045) I planned on addressing this ticket immediately
after the 8.4 release is cut if not sooner.{quote}
+1
> Collapse/Expand and Grouping are not designed to work together, we should
> fail requests that specify both gracefully
> --------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-13970
> URL: https://issues.apache.org/jira/browse/SOLR-13970
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Munendra S N
> Priority: Major
> Attachments: SOLR-13970.patch, SOLR-13970.patch, SOLR-13970.patch,
> SOLR-13970.patch
>
>
> Expand/Collapse was conceived as orthogonal to grouping, and there are odd
> interactions when both are specified. If these two options are specified, we
> should reject the query with an informative message.
> Shorter term, making this explicit in the documents would be helpful.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
