[ 
https://issues.apache.org/jira/browse/SOLR-13970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985997#comment-16985997
 ] 

Munendra S N commented on SOLR-13970:
-------------------------------------

 [^SOLR-13970.patch] 
This includes
* explicit error when either collapse/expand is specified with Grouping
* SOLR-5230 added a test to verify {{DelegatingCollector#finish()}} call. 
Since, collapse can't be used with Grouping. I have modified and moved the test 
{{TestGroupingSearch}}. Here, test use significantTerms which internally uses 
{{DelegatingCollector}}
* Ref-guide update

[~erickerickson] could you please review ?

> Collapse/Expand and Grouping are not designed to work together, we should 
> fail requests that specify both gracefully
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-13970
>                 URL: https://issues.apache.org/jira/browse/SOLR-13970
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-13970.patch
>
>
> Expand/Collapse was conceived as orthogonal to grouping, and there are odd 
> interactions when both are specified. If these two options are specified, we 
> should reject the query with an informative message.
> Shorter term, making this explicit in the documents would be helpful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to