dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350480886
########## File path: lucene/core/src/java/org/apache/lucene/search/QueryVisitor.java ########## @@ -37,8 +39,9 @@ */ public void consumeTerms(Query query, Term... terms) { } - // TODO it would be nice to have a way to consume 'classes' of Terms from - // things like AutomatonQuery + public void consumeTermsMatching(Query query, String field, ByteRunAutomaton automaton) { + visitLeaf(query); // default impl for BWC Review comment: is "BWC" back-compat? Please spell out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org