dsmiley commented on a change in pull request #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350480740
########## File path: lucene/core/src/java/org/apache/lucene/util/automaton/ByteRunAutomaton.java ########## @@ -44,4 +46,45 @@ public boolean run(byte[] s, int offset, int length) { } return accept[p]; } + + public CharArrayMatcher asCharArrayMatcher(String label) { Review comment: I really like this. Obviously this method and public classes etc. will need javadoc but you'll get to that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org