dsmiley commented on a change in pull request #1037: LUCENE-9062:
QueryVisitor.consumeTermsMatching
URL: https://github.com/apache/lucene-solr/pull/1037#discussion_r350728515
##########
File path:
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/FieldOffsetStrategy.java
##########
@@ -193,13 +193,13 @@ protected void createOffsetsEnumsForAutomata(Terms
termsIndex, int doc, List<Off
}
for (int i = 0; i < automata.length; i++) {
- CharArrayMatcher automaton = automata[i];
+ LabelledCharArrayMatcher automaton = automata[i];
List<PostingsEnum> postingsEnums = automataPostings.get(i);
if (postingsEnums.isEmpty()) {
continue;
}
- // Build one OffsetsEnum exposing the automata.toString as the term, and
the sum of freq
- BytesRef wildcardTerm = new BytesRef(automaton.toString());
+ // Build one OffsetsEnum exposing the automaton label as the term, and
the sum of freq
Review comment:
I wonder if we should stop calling these things "automata" and now call them
"matcher"? even if just in some method like perhaps this one. Automata is a
bit of an implementation detail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
