[
https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981195#comment-16981195
]
Erick Erickson commented on SOLR-13952:
---------------------------------------
Yes I did see your comments. And I spend a day re-doing it so _substantive_
changes are not included. This all suppress warnings, etc. Next up is
substantive changes. See SOLR-13964. I'm a bit frustrated too, this feels like
swimming upstream to try to make progress.
"did you take what Mark did blindly"
No. I admit I didn't test each and every SuppressWarning to see if it really
did suppress a warning after some spot-checking. If I'd done it blindly, I'd
have pushed all the files changed by "ant regenerate" (another half day trying
to get to run) and the manual changes to generated files rather than save
untangling those for a different JIRA.
"did you...notice the fully qualified class references."
Yes I did. Static imports can be ambiguous if two or more static imports define
the same variable. Which I've run into more than once in our code. So these
changes, while ugly, are arguably more correct. I'm "iffy" on this due to the
fact that they _are_ ugly, so if they were changed back I wouldn't mind. Feel
free.
I'll change the title and "CHANGES.txt" when I work on the next related JIRA.
Your point about what this looks like to someone else (or even me) 6 months
down the road is well taken.
> Separate out Gradle-specific code from other (mostly test) changes and commit
> separately
> ----------------------------------------------------------------------------------------
>
> Key: SOLR-13952
> URL: https://issues.apache.org/jira/browse/SOLR-13952
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13952.patch, fordavid.patch
>
>
> The gradle_8 branch has many changes unrelated to gradle. It would be much
> easier to work on the gradle parts if these were separated. So here's my plan:
> This turned out not to be as hard as I expected. I'll create a sub-task for
> the functional changes and use this one for the non-functional changes.
> Non-functional changes are the overwhelming majority of changes. There are a
> few categories of change here:
> * SuppressWarnings, rawtypes, deprecated.
> * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter
> and QuickPatchThreadsFilter. These are know thread leaks from third-party
> products (IBM Java, and a Log4J2 thread was added)
> * some static imports were removed
> * some reformatting, given that this whole patch is not about functional
> changes I decided to leave them in.
> * Some very minor code changes:
> ** change "new Path(leaderPath).getParent().toString();" to
> "Paths.get(leaderPath).getParent().toString();"
> ** mods like new HashMap(); <- new HashMap<>();
> * Log messages added
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
