[
https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980771#comment-16980771
]
Erick Erickson commented on SOLR-13952:
---------------------------------------
Thanks for letting me know about XmlOffsetCorrector.
re: one big commit. There are over 200 (?) separate files affected, the vast
majority of them follow the pattern:
{code}
@SuppressWarning blah blah blah
{code}
Mostly for deprecations and the like and another group for thread leaks from
other packages that we don't control and shouldn't fail suites because of
thread leaks in them.
There are maybe 3-4 about matters like this. And this one (XmlOffsetCorrector)
doesn't count since I'm going to revert it on your advice.
I'm not willing to create a huge number of tickets for this. Look at the bright
side, at least the gradle branch won't have them (soon I hope).
The goal here is to peel this out of the Gradle build exactly to introduce
_some_ separation of changes in the gradle branch without losing Mark's efforts
at test improvement (or, in many cases compiler warnings).
So what do you suggest here? I'm not going to do a lot of busy work to address
this.
> Separate out Gradle-specific code from other (mostly test) changes and commit
> separately
> ----------------------------------------------------------------------------------------
>
> Key: SOLR-13952
> URL: https://issues.apache.org/jira/browse/SOLR-13952
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: fordavid.patch
>
>
> The gradle_8 branch has many changes unrelated to gradle. It would be much
> easier to work on the gradle parts if these were separated. So here's my plan:
> - establish a branch to use for the non-gradle parts of the gradle_8 branch
> and commit separately. For a first cut, I'll make all the changes I'm
> confident of, and mark the others with nocommits so we can iterate and decide
> when to merge to master and 8x.
> - create a "gradle_9" branch that hosts only the gradle changes for us all to
> iterate on.
> I hope to have a preliminary cut at this over the weekend.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
