[
https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981164#comment-16981164
]
David Smiley commented on SOLR-13952:
-------------------------------------
Some of the changes here don't look like a good idea at all, and I think should
be reverted. Did you really look over everything? See
ExtractingDocumentLoader and notice the fully qualified class references.
Did you approve of that? Ditto for WordDelimiterFilterFactory. Why shouldn't
take what Mark did blindly. There may be other places but I did a little spot
check.
_At least_ the changes here are, from what I've seen, limited to minor compile
time matters, and thus I don't mind one commit.
> Separate out Gradle-specific code from other (mostly test) changes and commit
> separately
> ----------------------------------------------------------------------------------------
>
> Key: SOLR-13952
> URL: https://issues.apache.org/jira/browse/SOLR-13952
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13952.patch, fordavid.patch
>
>
> The gradle_8 branch has many changes unrelated to gradle. It would be much
> easier to work on the gradle parts if these were separated. So here's my plan:
> This turned out not to be as hard as I expected. I'll create a sub-task for
> the functional changes and use this one for the non-functional changes.
> Non-functional changes are the overwhelming majority of changes. There are a
> few categories of change here:
> * SuppressWarnings, rawtypes, deprecated.
> * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter
> and QuickPatchThreadsFilter. These are know thread leaks from third-party
> products (IBM Java, and a Log4J2 thread was added)
> * some static imports were removed
> * some reformatting, given that this whole patch is not about functional
> changes I decided to leave them in.
> * Some very minor code changes:
> ** change "new Path(leaderPath).getParent().toString();" to
> "Paths.get(leaderPath).getParent().toString();"
> ** mods like new HashMap(); <- new HashMap<>();
> * Log messages added
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
