[ 
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975688#comment-16975688
 ] 

Munendra S N commented on SOLR-13912:
-------------------------------------

 [^SOLR-13912.patch] 
Above patch includes
* Ref-Guide changes
* uncommenting tests from SOLR-11695
* Aggregation name is {{countvals}}

{quote}do we not have any existing general purpose abstractions for the 
differences between Accumulating values over SortedSetDV, SortedNumericDV that 
could be reuse here w/simple subclasses the only worry about the 
"counting"{quote}
We don't have general purpose abstractions right now. Most Acc are bound to 
particular Agg this is true especially for Multivalued case. 
In the latest patch, I have added abstractions for DocValues fields and made 
some minor refactoring in UniqueAgg and HllAgg. Hopefully, this could be 
improved further while adding support for multivalued fields in other 
Aggregations

[~hossman]
Could you please review this once more? Let me know if any changes required

> Support Count aggregation in JSON facet module
> ----------------------------------------------
>
>                 Key: SOLR-13912
>                 URL: https://issues.apache.org/jira/browse/SOLR-13912
>             Project: Solr
>          Issue Type: Sub-task
>          Components: Facet Module
>            Reporter: Munendra S N
>            Priority: Major
>         Attachments: SOLR-13912.patch, SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to 
> StatsComponent's count



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to