[
https://issues.apache.org/jira/browse/SOLR-13912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972054#comment-16972054
]
Chris M. Hostetter commented on SOLR-13912:
-------------------------------------------
Munendra: I skimmed your patch w/o testing it in depth -- here are some misc
thoughts....
* I'm surprised by the need for the new classes BaseDVAcc, CountMultiValuedAcc,
SortedSetDVAcc, & SortedNumericAcc -- all of which are specific to
CountValsAgg. do we not have any existing general purpose abstractions for the
differences between Accumulating values over SortedSetDV, SortedNumericDV that
could be reuse here w/simple subclasses the _only_ worry about the "counting"
* new aggregations need to be covered in the ref guide:
https://lucene.apache.org/solr/guide/8_2/json-facet-api.html#stat-facet-functions
* as noted in the parent issue SOLR-11695 we have existing commented out test
coverage adapted from legacy facts+stats testing that refers to {{SOLR-1169}}
in java comments -- if we're adding this functionality now, then those tests
should be un-commented (and pass)
> Support Count aggregation in JSON facet module
> ----------------------------------------------
>
> Key: SOLR-13912
> URL: https://issues.apache.org/jira/browse/SOLR-13912
> Project: Solr
> Issue Type: Sub-task
> Components: Facet Module
> Reporter: Munendra S N
> Priority: Major
> Attachments: SOLR-13912.patch
>
>
> Add a count aggregation in JSON Facet module which behaves similar to
> StatsComponent's count
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
