rdblue commented on code in PR #6717:
URL: https://github.com/apache/iceberg/pull/6717#discussion_r1114655196
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -722,6 +757,16 @@ private Table loadFromPathIdentifier(PathIdentifier ident)
{
long snapshotIdAsOfTime = SnapshotUtil.snapshotIdAsOfTime(table,
asOfTimestamp);
return new SparkTable(table, snapshotIdAsOfTime, !cacheEnabled);
+ } else if (branch != null) {
+ Snapshot branchSnapshot = table.snapshot(branch);
+ Preconditions.checkArgument(
+ branchSnapshot != null, "Cannot find snapshot associated with branch
name: %s", branch);
+ return new SparkTable(table, branchSnapshot.snapshotId(), !cacheEnabled);
+ } else if (tag != null) {
Review Comment:
This doesn't follow the spacing of the other branches. Can you introduce
similar whitespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
