amogh-jahagirdar commented on code in PR #6717:
URL: https://github.com/apache/iceberg/pull/6717#discussion_r1106177816
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java:
##########
@@ -124,11 +128,15 @@ private Spark3Util.CatalogAndIdentifier
catalogAndIdentifier(CaseInsensitiveStri
Long snapshotId = propertyAsLong(options, SparkReadOptions.SNAPSHOT_ID);
Long asOfTimestamp = propertyAsLong(options,
SparkReadOptions.AS_OF_TIMESTAMP);
+ String branch = options.get(SparkReadOptions.BRANCH);
+ String tag = options.get(SparkReadOptions.TAG);
Preconditions.checkArgument(
- asOfTimestamp == null || snapshotId == null,
- "Cannot specify both snapshot-id (%s) and as-of-timestamp (%s)",
+ Stream.of(snapshotId, asOfTimestamp, branch,
tag).filter(Objects::nonNull).count() <= 1,
+ "Can specify at most one of snapshot-id (%s), as-of-timestamp (%s),
branch (%s) and tag (%s)",
Review Comment:
I think "Can specify only one of snapshot-id (%s), as-of-timestamp (%s),
branch, tag..." is more clear imo
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -654,6 +659,21 @@ private Table load(Identifier ident) {
return new SparkTable(table, snapshotId, !cacheEnabled);
}
+ Matcher branch = BRANCH.matcher(ident.name());
+ if (branch.matches()) {
+ Snapshot branchSnapshot = table.snapshot(branch.group(1));
+ if (branchSnapshot != null) {
+ return new SparkTable(table, branchSnapshot.snapshotId(),
!cacheEnabled);
+ }
+ }
+
+ Matcher tag = TAG.matcher(ident.name());
+ if (tag.matches()) {
+ Snapshot tagSnapshot = table.snapshot(tag.group(1));
+ if (tagSnapshot != null) {
+ return new SparkTable(table, tagSnapshot.snapshotId(),
!cacheEnabled);
+ }
+ }
Review Comment:
Nit: Newline after the if block/before the comment starts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
