jackye1995 commented on code in PR #6717:
URL: https://github.com/apache/iceberg/pull/6717#discussion_r1103692664
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCachedTableCatalog.java:
##########
@@ -144,23 +149,49 @@ private Pair<Table, Long> load(Identifier ident) throws
NoSuchTableException {
if (snapshotBasedMatcher.matches()) {
snapshotId = Long.parseLong(snapshotBasedMatcher.group(1));
}
+
+ Matcher branchBasedMatcher = BRANCH.matcher(meta);
+ if (branchBasedMatcher.matches()) {
+ branch = branchBasedMatcher.group(1);
+ }
+
+ Matcher tagBasedMatcher = BRANCH.matcher(meta);
+ if (tagBasedMatcher.matches()) {
+ tag = tagBasedMatcher.group(1);
+ }
}
Preconditions.checkArgument(
- asOfTimestamp == null || snapshotId == null,
- "Cannot specify both snapshot and timestamp for time travel: %s",
- ident);
+ Stream.of(snapshotId, asOfTimestamp, branch,
tag).filter(Objects::nonNull).count() <= 1,
+ "Can specify at most one of snapshot-id (%s), as-of-timestamp (%s),
and snapshot-ref (%s)",
+ snapshotId,
+ asOfTimestamp,
+ branch);
Table table = TABLE_CACHE.get(key);
if (table == null) {
throw new NoSuchTableException(ident);
}
+ long snapshotIdFromTimeTravel = -1L;
Review Comment:
Actually, after reading all the if else statements, I am not sure if we
really need this, why not just do `return Pair.of(table,
table.snapshot(branch).snapshotId())` and `return Pairs.of(table,
table.snapshot(tag).snapshotId())` in the branch and tag case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
