rdblue commented on code in PR #6717:
URL: https://github.com/apache/iceberg/pull/6717#discussion_r1114655926
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java:
##########
@@ -124,11 +128,15 @@ private Spark3Util.CatalogAndIdentifier
catalogAndIdentifier(CaseInsensitiveStri
Long snapshotId = propertyAsLong(options, SparkReadOptions.SNAPSHOT_ID);
Long asOfTimestamp = propertyAsLong(options,
SparkReadOptions.AS_OF_TIMESTAMP);
+ String branch = options.get(SparkReadOptions.BRANCH);
+ String tag = options.get(SparkReadOptions.TAG);
Preconditions.checkArgument(
- asOfTimestamp == null || snapshotId == null,
- "Cannot specify both snapshot-id (%s) and as-of-timestamp (%s)",
+ Stream.of(snapshotId, asOfTimestamp, branch,
tag).filter(Objects::nonNull).count() <= 1,
+ "Can specify at most one of snapshot-id (%s), as-of-timestamp (%s),
branch (%s) and tag (%s)",
Review Comment:
Also missing the comma after branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
