aokolnychyi commented on code in PR #6776:
URL: https://github.com/apache/iceberg/pull/6776#discussion_r1100982048
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkCopyOnWriteScan.java:
##########
@@ -123,8 +127,17 @@ public void filter(Filter[] filters) {
tasks().stream()
.filter(file ->
fileLocations.contains(file.file().path().toString()))
.collect(Collectors.toList());
+
+ LOG.info(
+ "{}/{} tasks for table {} matched runtime file filter",
+ filteredTasks.size(),
+ tasks().size(),
+ table().name());
+
resetTasks(filteredTasks);
}
+ } else {
+ LOG.warn("Unsupported runtime filter {}", filter);
}
Review Comment:
I overlooked this in the initial implementation. There should be no use case
where we can't convert a runtime filter for the copy-on-write scan. If it
happens, we should warn the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
