szehon-ho commented on code in PR #6776:
URL: https://github.com/apache/iceberg/pull/6776#discussion_r1100776061
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -140,7 +140,7 @@ protected Statistics estimateStatistics(Snapshot snapshot) {
// estimate stats using snapshot summary only for partitioned tables
// (metadata tables are unpartitioned)
if (!table.spec().isUnpartitioned() && filterExpressions.isEmpty()) {
- LOG.debug("Using table metadata to estimate table statistics");
+ LOG.debug("Using snapshot metadata to estimate statistics for table {}",
table.name());
Review Comment:
Should we also log snapshot id?
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkCopyOnWriteScan.java:
##########
@@ -123,8 +127,17 @@ public void filter(Filter[] filters) {
tasks().stream()
.filter(file ->
fileLocations.contains(file.file().path().toString()))
.collect(Collectors.toList());
+
+ LOG.info(
Review Comment:
What do you think put filter in this log as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
