rdblue commented on code in PR #5234:
URL: https://github.com/apache/iceberg/pull/5234#discussion_r1083195038
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -460,8 +471,8 @@ private void validateNoNewDeletesForDataFiles(
* @param dataFilter an expression used to find new conflicting delete files
*/
protected void validateNoNewDeleteFiles(
- TableMetadata base, Long startingSnapshotId, Expression dataFilter) {
- DeleteFileIndex deletes = addedDeleteFiles(base, startingSnapshotId,
dataFilter, null);
+ TableMetadata base, Long startingSnapshotId, Expression dataFilter,
Snapshot parent) {
Review Comment:
I think a lot of the `revapi` problems are probably related to adding
`parent` to these methods. We should add the older version back that passes
`base.currentSnapshot()` and mark it deprecated, to be removed in 1.3.0. That
will take care of at least some of the breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
