rdblue commented on code in PR #5234:
URL: https://github.com/apache/iceberg/pull/5234#discussion_r1083099208
##########
core/src/main/java/org/apache/iceberg/BaseReplacePartitions.java:
##########
@@ -79,23 +79,32 @@ public ReplacePartitions validateNoConflictingData() {
return this;
}
+ @Override
+ public BaseReplacePartitions toBranch(String branch) {
+ targetBranch(branch);
+ return this;
+ }
+
@Override
public void validate(TableMetadata currentMetadata, Snapshot snapshot) {
if (validateConflictingData) {
if (dataSpec().isUnpartitioned()) {
- validateAddedDataFiles(currentMetadata, startingSnapshotId,
Expressions.alwaysTrue());
+ validateAddedDataFiles(
+ currentMetadata, startingSnapshotId, Expressions.alwaysTrue(),
snapshot);
} else {
- validateAddedDataFiles(currentMetadata, startingSnapshotId,
replacedPartitions);
+ validateAddedDataFiles(currentMetadata, startingSnapshotId,
replacedPartitions, snapshot);
Review Comment:
Minor: I think it makes more sense to use `parent` rather than `snapshot`
for the parent snapshot variable. Not a blocker, but it makes it easier to
understand what's going on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
