rdblue commented on code in PR #5234: URL: https://github.com/apache/iceberg/pull/5234#discussion_r1083109459
########## core/src/test/java/org/apache/iceberg/TestReplacePartitions.java: ########## @@ -114,20 +122,22 @@ public void testReplaceAndMergeOnePartition() { // ensure the overwrite results in a merge table.updateProperties().set(TableProperties.MANIFEST_MIN_MERGE_COUNT, "1").commit(); - table.newFastAppend().appendFile(FILE_A).appendFile(FILE_B).commit(); + table.newFastAppend().appendFile(FILE_A).appendFile(FILE_B).toBranch(branch).commit(); Review Comment: Why not use the `commit` method in these tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org