rdblue commented on code in PR #5234:
URL: https://github.com/apache/iceberg/pull/5234#discussion_r1083112330
##########
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##########
@@ -39,18 +39,32 @@
import org.apache.iceberg.relocated.com.google.common.collect.Sets;
import org.junit.Assert;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+@RunWith(Parameterized.class)
public class TestRowDelta extends V2TableTestBase {
+
+ private final String branch;
+
+ @Parameterized.Parameters(name = "branch = {0}")
+ public static Object[] parameters() {
+ return new Object[][] {
+ new Object[] {"main"}, new Object[] {"testBranch"},
+ };
+ }
+
+ public TestRowDelta(String branch) {
+ this.branch = branch;
+ }
+
@Test
public void testAddDeleteFile() {
- table
- .newRowDelta()
- .addRows(FILE_A)
- .addDeletes(FILE_A_DELETES)
- .addDeletes(FILE_B_DELETES)
- .commit();
+ SnapshotUpdate rowDelta =
+
table.newRowDelta().addRows(FILE_A).addDeletes(FILE_A_DELETES).addDeletes(FILE_B_DELETES);
- Snapshot snap = table.currentSnapshot();
+ commit(table, rowDelta, branch);
Review Comment:
Odd spacing here. I'd expect the commit to come after rowDelta insteadd of
being combined with the latestSnapshot call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
