jackye1995 commented on code in PR #6617:
URL: https://github.com/apache/iceberg/pull/6617#discussion_r1082118919
##########
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSqlExtensionsAstBuilder.scala:
##########
@@ -267,6 +286,12 @@ class IcebergSqlExtensionsAstBuilder(delegate:
ParserInterface) extends IcebergS
private def typedVisit[T](ctx: ParseTree): T = {
ctx.accept(this).asInstanceOf[T]
}
+
+ private def timeRetain(unit: String, duration: Long): Long =
unit.toUpperCase(Locale.ENGLISH) match {
+ case "MONTHS" => 30 * TimeUnit.DAYS.toMillis(duration)
+ case "DAYS" | "HOURS" | "MINUTES" =>
TimeUnit.valueOf(unit.toUpperCase(Locale.ENGLISH)).toMillis(duration)
Review Comment:
do we still need to use match statement? The parser will only allow these
values, so we should be able to directly parse it to TimeUnit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
