hililiwei commented on code in PR #6617:
URL: https://github.com/apache/iceberg/pull/6617#discussion_r1080806243
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -73,6 +73,13 @@ statement
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
+ | ALTER TABLE multipartIdentifier CREATE BRANCH identifier (AS OF VERSION
snapshotId)? (snapshotRetentionClause)? (RETAIN snapshotRefRetain
snapshotRefRetainTimeUnit)? #createBranch
Review Comment:
Sounds reasonable to me.
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -73,6 +73,13 @@ statement
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
+ | ALTER TABLE multipartIdentifier CREATE BRANCH identifier (AS OF VERSION
snapshotId)? (snapshotRetentionClause)? (RETAIN snapshotRefRetain
snapshotRefRetainTimeUnit)? #createBranch
+ ;
+
+snapshotRetentionClause
+ : WITH SNAPSHOT RETENTION numSnapshots SNAPSHOTS
+ | WITH SNAPSHOT RETENTION snapshotRetain snapshotRetainTimeUnit
+ | WITH SNAPSHOT RETENTION numSnapshots SNAPSHOTS snapshotRetain
snapshotRetainTimeUnit
Review Comment:
This skips illegal statements : `WITH SNAPSHOT RETENTION`
or we can use
`WITH SNAPSHOT RETENTION ((numSnapshots SNAPSHOTS)? (snapshotRetain
snapshotRetainTimeUnit)? | numSnapshots SNAPSHOTS snapshotRetain
snapshotRetainTimeUnit )`?
But it's not intuitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
