jackye1995 commented on code in PR #6617:
URL: https://github.com/apache/iceberg/pull/6617#discussion_r1082010234
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -73,6 +73,13 @@ statement
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
+ | ALTER TABLE multipartIdentifier CREATE BRANCH identifier (AS OF VERSION
snapshotId)? (snapshotRetentionClause)? (RETAIN snapshotRefRetain
snapshotRefRetainTimeUnit)? #createBranch
+ ;
+
+snapshotRetentionClause
+ : WITH SNAPSHOT RETENTION numSnapshots SNAPSHOTS
+ | WITH SNAPSHOT RETENTION snapshotRetain snapshotRetainTimeUnit
+ | WITH SNAPSHOT RETENTION numSnapshots SNAPSHOTS snapshotRetain
snapshotRetainTimeUnit
Review Comment:
I see, I will leave it here to see if anyone has better suggestions. I am
not an Antlr expert 😝
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
