rdblue commented on code in PR #6617:
URL: https://github.com/apache/iceberg/pull/6617#discussion_r1083572053


##########
spark/v3.3/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ExtendedDataSourceV2Strategy.scala:
##########
@@ -61,6 +62,9 @@ case class ExtendedDataSourceV2Strategy(spark: SparkSession) 
extends Strategy wi
     case AddPartitionField(IcebergCatalogAndIdentifier(catalog, ident), 
transform, name) =>
       AddPartitionFieldExec(catalog, ident, transform, name) :: Nil
 
+    case CreateBranch(IcebergCatalogAndIdentifier(catalog, ident), _, _, _, _, 
_) =>
+      CreateBranchExec(catalog, ident, plan.asInstanceOf[CreateBranch]) :: Nil

Review Comment:
   Why does this pass the logical plan rather than passing the necessary 
information? Is it just to avoid a longer line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to