Fokko commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1022876945


##########
python/pyiceberg/typedef.py:
##########
@@ -36,3 +38,7 @@ def update(self, *args: Any, **kwargs: Any) -> None:
 Identifier = Tuple[str, ...]
 Properties = Dict[str, str]
 RecursiveDict = Dict[str, Union[str, "RecursiveDict"]]  # type: ignore
+
+LITERAL_TYPES = Union[str, int, bool, float, bytes, Decimal, UUID]
+
+T = TypeVar("T", bound=LITERAL_TYPES)

Review Comment:
   The main thing is that I'd like to bind the `LITERAL_TYPES`, otherwise we 
need to do that locally everywhere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to