Fokko commented on code in PR #6139: URL: https://github.com/apache/iceberg/pull/6139#discussion_r1022503190
########## python/pyiceberg/expressions/literals.py: ########## @@ -108,7 +110,7 @@ def __ge__(self, other): @singledispatch -def literal(value) -> Literal: +def literal(value: Any) -> Literal[T]: Review Comment: ~~Yes, that's the case for Python as well. I agree that ideally we indeed want `def literal(value: T) -> Literal[T]`. Otherwise, the type checker won't complain if you put in something non-sensical. I'm happy to fix this, but I'd rather do it in another PR since it is not really related to the dataclasses.~~ Taking a look right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
